Resolve TODOs by backporting async/await code #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
commented
Jun 20, 2023
| @@ -498,10 +500,23 @@ open class WordPressComRestApi: NSObject { | |||
| request.httpBody = parameters.percentEncoded() | |||
| } | |||
|
|
|||
| return try await urlSession.data(for: request, delegate: nil) | |||
| return try await withCheckedThrowingContinuation { continuation in | |||
There was a problem hiding this comment.
urlSession.data(for:) is only available in iOS15, so I had to wrap the method in async/await myself
There was a problem hiding this comment.
Jetpack/WordPress will soon support iOS 15 and above only and WooCommerce already does.
Your diff doesn't add much complexity, but I wonder if it would be cleaner to bump the library to iOS 15 instead.
|
@jkmassel it looks like the tests are hanging after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While digging into async issues, I came across a couple of TODOs that were pretty quick to clean up. While we can't switch to async/await entirely at this point, enabling backporting is a step toward allowing it (even if just for use in our test suite).
Testing Details
Ensure tests pass.
versionin the.podspecfile.CHANGELOG.mdif necessary.