[Build] Update Kotlin to 1.9.22 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update isn't that necessary, but should be considered anyway as it will do the following: - Align this library, to that Kotlin version, which is already used by most of this library's clients and libraries. - Unblock the usage of the dependency analysis Gradle plugin for this project. - Prepares this project for the Kotlin 2+ major update.
This change is necessary because otherwise the build fails with the below exception: ------------------------------------------------------------------------ > Task :mediapicker:kaptDebugKotlin FAILED Annotation processors discovery from compile classpath is deprecated. Set 'kapt.include.compile.classpath=false' to disable discovery. Run the build with '--info' for more details. FAILURE: Build completed with 2 failures. 1: Task failed with an exception. ----------- * What went wrong: Execution failed for task ':mediapicker:source-gif:kaptDebugKotlin'. > A failure occurred while executing org.jetbrains.kotlin.gradle .internal.KaptWithoutKotlincTask$KaptExecutionWorkAction > java.lang.reflect.InvocationTargetException (no error message) ------------------------------------------------------------------------ FYI: This Dagger update is relatively safe as it is only about couple of bug fixes: - [2.46]: https://github.com/google/dagger/releases/tag/dagger-2.46 - Fixed #3701 and #3838. Updated Dagger to kotlinx metadata 0.6.0. (7cf53031) - [2.46.1]: https://github.com/google/dagger/releases/tag/dagger-2.46.1 - Fixed #3701: Shade kotlinx metadata in Dagger's artifacts to prevent upstream dependency issues. (d593e01)
1 task
wzieba
approved these changes
Jul 5, 2024
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required By:
Dependency Analysis PRThis PR updates Kotlin to 1.9.22.
Description
This update isn't that necessary, but should be considered anyway as it will do the following:
Test
sampleappexample app.Media Picker, or via composite builds, and see if it works as expected.