Issue/21283 no connection message #21287
Conversation
Generated by 🚫 Danger |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21287-d1699b2 | |
| Commit | d1699b2 | |
| Direct Download | wordpress-prototype-build-pr21287-d1699b2.apk |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21287-d1699b2 | |
| Commit | d1699b2 | |
| Direct Download | jetpack-prototype-build-pr21287-d1699b2.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21287 +/- ##
==========================================
- Coverage 40.24% 40.23% -0.01%
==========================================
Files 1535 1535
Lines 70232 70241 +9
Branches 11545 11549 +4
==========================================
- Hits 28262 28259 -3
- Misses 39523 39535 +12
Partials 2447 2447 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Nice improvement. 👏🏻 Thanks for doing this. The following are suggestions we could implement now or later.
The a11y label for the offline image (struck through cloud) has an odd, likely outdated alt text of "Person reading device with notifications." In fact, I noted several images use this same alt text (e.g., device media permissions illustration).
I note that when a search field is focused, a screen reader is unable to access the network offline message. One can only move focus to the visible illustration, which includes the aforementioned odd alt text. I.e., when the search field is focused, it is not clear at all that a lack of network connection will disrupt the experience. If one dismisses the virtual keyboard, then you can move screen reader focus to the error message and retry button. This experience is present within the GIF library, free stock media, and editor media insert flows.
Additionally, I note there are slight divergences for the design of these screens. Some of it likely pre-existed, unsure if the new Users screen differences were intentional.
| Media Add | Media Insert | Users |
|---|---|---|
Oh, that's not good. Looks like the pre-existing offline screens all use a custom view (
I filed #21288 for this as it's a pre-existing issue.
Thanks for catching that! I've adjusted the user list offline image size, margin, & tint to more closely match the pre-existing screens. The user list Retry button is rounded because that screen uses Material 3 which defaults to rounded buttons, whereas the other screens use Material 2. I've changed the user list button to match the pre-existing screens |
|
Fixes #21283
Prior to this PR, there were a few places in the app where the user would see both "No network available" and "There is no network available" when there's no network connection. This PR changes this so only the second message appears, and a Retry button was added to the self-hosted user list for consistency.
The following four areas contain this change: