Use underscored titles when querying for live pages

Bug: T362457
wikimedia · Apr 14, 2024 · 8344a94 · 8344a94
1 parent 8f05de2
commit 8344a94
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/Controller/AppController.php b/src/Controller/AppController.php
@@ -185,13 +185,13 @@ public function decorateRecords( array $rows, WikiRepository $wikiRepo ): array
 				// Basic revision info all goes in the $row data.
 				$row = array_merge( $row, $extraData );
 			}
-
+			$revUserTextUnderscored = str_replace( ' ', '_', $row['rev_user_text'] );
 			return new Record(
 				$row,
 				$editCounts[$row['rev_user_text']] ?? null,
 				isset( $livePages[$row['page_namespace']][$row['page_title']] ),
-				isset( $livePages['2'][$row['rev_user_text']] ),
-				isset( $livePages['3'][$row['rev_user_text']] ),
+				isset( $livePages['2'][$revUserTextUnderscored] ),
+				isset( $livePages['3'][$revUserTextUnderscored] ),
 				$livePages[$row['page_namespace']][$row['page_title']] ?? []
 			);
 		}, $newRows );

diff --git a/src/Repository/WikiRepository.php b/src/Repository/WikiRepository.php
@@ -135,7 +135,9 @@ public function getLivePagesWithWikiProjects( array $titlesByNs ): array {
 		}
 
 		foreach ( $titlesByNs as $nsId => $titles ) {
-			$titles = array_unique( $titles );
+			$titles = array_map( static function ( $title ) {
+				return str_replace( ' ', '_', $title );
+			}, array_unique( $titles ) );
 			$qb->orWhere( "(
 				page_namespace = :ns_$nsId
 				AND page_title IN (:titles_$nsId)