Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace origin with storage key for BroadcastChannel partitioning #7567

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Replace origin with storage key for BroadcastChannel partitioning #7567

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6e5eb3
Replace origin with storage key for BroadcastChannel partitioning
recvfrom Feb 2, 2022
08efb49
Use new storage key algorithms + address review feedback
recvfrom Feb 11, 2022
411793c
Address review feedback - sourceStorageKey can no longer be failure
recvfrom Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4126,6 +4126,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
<ul class="brief">
<li><dfn data-x-href="https://storage.spec.whatwg.org/#obtain-a-local-storage-bottle-map">obtain a local storage bottle map</dfn></li>
<li><dfn data-x-href="https://storage.spec.whatwg.org/#obtain-a-session-storage-bottle-map">obtain a session storage bottle map</dfn></li>
<li><dfn data-x-href="https://storage.spec.whatwg.org/#obtain-a-storage-key">obtain a storage key</dfn></li>
<li><dfn data-x-href="https://storage.spec.whatwg.org/#storage-proxy-map">storage proxy map</dfn></li>
<li><dfn data-x-href="https://storage.spec.whatwg.org/#legacy-clone-a-browsing-session-storage-shed">legacy-clone a browsing session storage shed</dfn></li>
</ul>
Expand Down Expand Up @@ -102375,16 +102376,20 @@ interface <dfn interface>BroadcastChannel</dfn> : <span>EventTarget</span> {
<li><p>Let <var>sourceOrigin</var> be <span>this</span>'s <span>relevant settings object</span>'s
<span data-x="concept-settings-object-origin">origin</span>.</p></li>

<li><p>Let <var>sourceStorageKey</var> be the result of running <span>obtain a storage key</span>
with <span>this</span>'s <span>relevant settings object</span>.</p></li>

<li><p>If <var>sourceStorageKey</var> is failure, then return.</p><li>

<li>
<p>Let <var>destinations</var> be a list of <code>BroadcastChannel</code> objects that
match the following criteria:</p>

<ul>
<li><p>They are <span>eligible for messaging</span>.</p></li>

<li><p>Their <span>relevant settings object</span>'s <span
data-x="concept-settings-object-origin">origin</span> is <span>same origin</span> with
<var>sourceOrigin</var>.</p></li>
<li><p>The result of running <span>obtain a storage key</span> with their <span>relevant
settings object</span> is not failure and is equal to <var>sourceStorageKey</var>.</p></li>
domenic marked this conversation as resolved.
Show resolved Hide resolved

<li><p>Their <span>channel name</span> <span>is</span> <span>this</span>'s <span>channel
name</span>.</p></li>
Expand Down