feat(exit-code): configure exit code on warning #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxes3
force-pushed
the
feature/1-configure-exit-code-on-warnings
branch
2 times, most recently
from
3d9a88f
to
3cffd38
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2 +/- ##
==============================================
- Coverage 97.61% 84.11% -13.51%
- Complexity 100 109 +9
==============================================
Files 18 19 +1
Lines 294 384 +90
==============================================
+ Hits 287 323 +36
- Misses 7 61 +54
☔ View full report in Codecov by Sentry. |
tuxes3
force-pushed
the
feature/1-configure-exit-code-on-warnings
branch
from
3cffd38
to
f6e0456
Compare
tuxes3
force-pushed
the
feature/1-configure-exit-code-on-warnings
branch
from
f6e0456
to
150ac42
Compare
|
@xarem these checks are getting out of hand ... |
|
@tuxes3 in case of a warning, the http response code for the HTTP check is still 503. How about making it configurable like this? whatwedo_monitor:
endpoint:
api:
http_status_code:
warning: 503
critical: 503
command:
exit_code:
warning: 1
critical: 1In addition, please update the docs with the change. |
|
@xarem ready for second review |
xarem
reviewed
Jul 10, 2023
xarem
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Furthermore i removed all deprecations and made the bundle only usable starting symfony
6.3.That would mean we need to tag the next version
v2.0.0.Issue: #1