Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alfie #287

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Alfie #287

wants to merge 1 commit into from

Conversation

dmoonfire
Copy link
Contributor

@dmoonfire dmoonfire commented Sep 24, 2023

Add Alfie from https://buttsmithy.com/

The format attempts to normalize the date so it is in lexical order, otherwise everything comes in at things like 8.jpg for a comic that has over a thousand pages. There are a few exceptions (the if blocks) due to typos or mistakes.

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (85127de) 82.09% compared to head (9fadc2c) 82.01%.
Report is 19 commits behind head on master.

Files Patch % Lines
dosagelib/plugins/a.py 50.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
- Coverage   82.09%   82.01%   -0.08%     
==========================================
  Files          79       79              
  Lines        6642     6657      +15     
  Branches      525      527       +2     
==========================================
+ Hits         5453     5460       +7     
- Misses       1069     1077       +8     
  Partials      120      120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TobiX TobiX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit wary about adding many special cases. Sometimes the better solution is finding a better naming scheme for all files... Maybe just using the image file name like

  namer = joinPathPartsNamer((), (-3, -2, -1))

dosagelib/plugins/a.py Outdated Show resolved Hide resolved
dosagelib/plugins/a.py Outdated Show resolved Hide resolved
dosagelib/plugins/a.py Outdated Show resolved Hide resolved
@dmoonfire
Copy link
Contributor Author

I'm a bit wary about adding many special cases. Sometimes the better solution is finding a better naming scheme for all files... Maybe just using the image file name like

  namer = joinPathPartsNamer((), (-3, -2, -1))

I wasn't sure about this one. Alfie is on a WordPress site, but the image names are all pretty much two-digit fields like 85.jpg. There is also a lot of duplicates and it put everything out of order, that is why I went with the more complex parsing that also zero-padded to make sure they were (mostly) in display order. Also, InCase ent back and redid the first couple five years later so the file names are p-1 but the attachment URLs are the new date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants