Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve loading speed #7099

Open
wants to merge 29 commits into
base: 4.10.0
Choose a base branch
from
Open

Improve loading speed #7099

wants to merge 29 commits into from
+560 −213

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Oct 15, 2024 •
edited
Loading

Description

Improve loading speed

Issues Resolved

Closes #7084

Evidence

/check-stored-api

BEFORE

Average of 620 ms

image

AFTER

Average of 578 ms

image

/check-api

BEFORE

Average of 739,5 ms

image

AFTER
Average of 674 ms

image

Test

  1. Open DevTools, navigate to the Application tab, and click on "Clear site data".

    image

  2. Right-click the reload page button, then select "Empty Cache and Hard Reload."

    image

  3. Repeat these steps:

    Peek.2024-10-15.13-59.mp4

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@guidomodarelli guidomodarelli self-assigned this Oct 15, 2024
@guidomodarelli guidomodarelli linked an issue Oct 15, 2024 that may be closed by this pull request
Improve loading speed #7084
Open
@guidomodarelli
Fix loading speed issue (#7099)
0fe0f44
@guidomodarelli
Add WAZUH_ERROR_DAEMONS_NOT_READY constant to error messages
a71486b
@guidomodarelli
Add ERROR_CODES enum for error handling
fcd0024
@guidomodarelli
Refactor API routes to use controller functions directly
654ff15
@guidomodarelli
Refactor getCookieValueByName to handle undefined input
f1b4e46
@guidomodarelli
Update code to handle string error codes in ErrorResponse function
d9c7281
@guidomodarelli
Update queue job run function to handle context error
5b81eb8
@guidomodarelli
Update parameter type in getCookieValueByName function
310856d
@guidomodarelli
Add error handling for missing API parameters
4ab0edf
@guidomodarelli
Refactor error handling for consistency and readability
8502812
@guidomodarelli
Update Wazuh API controller methods and parameters
91f253a
@guidomodarelli
Remove unnecessary code for checking API availability.- Remove redund…
00867d0 
…ant variable assignment.- Remove commented out code for checking API parameters.- Simplify logic for handling missing API data
@guidomodarelli
Refactor route handlers to use async/await functions
f5e8e8c
@guidomodarelli
Refactor error handling to log messages as strings
51890e7
@guidomodarelli
Update OpenSearchDashboardsRequest and response types
2cf4394
@guidomodarelli
Update limit parameter type to Record<string, number>.
32ef2ac
@guidomodarelli
Update json2csvParser fields mapping in WazuhApiCtrl class
75ea03e
@guidomodarelli
Refactor handling of Wazuh API requests
9d65d97
@guidomodarelli
Fix Prettier issue:
a3caa44
@guidomodarelli
Add mock for API client's asInternalUser endpoint
fa8bea5
@guidomodarelli
Update error handling in WazuhApiCtrl class
8c6e364
@guidomodarelli
Update WazuhCorePluginStart type in kibana-services.ts
90421cf
@guidomodarelli
Add WzToken interface and adjust cookie value retrieval
efe7ac1
@guidomodarelli
Refactor route decorators for administrator & configuration API
74ca6d1
@guidomodarelli
Update import path for PluginInitializerContext
3880d7b
@guidomodarelli
Add resolveJsonModule to compilerOptions in tsconfig.json
865253a
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.12% ( 4178 / 29587 )
Branches 9.26% ( 1780 / 19216 )
Functions 13.8% ( 986 / 7140 )
Lines 14.31% ( 4075 / 28473 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@guidomodarelli guidomodarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve loading speed
1 participant
@guidomodarelli