Add vulnerability detection card in agent overview #7085
+400
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
|
|
chantal-kelm
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
| Test | Chrome | Firefox | Safari |
|---|---|---|---|
| Click on Vulnerability KPIs and check if redirects to the dashboard with filters and agent pinned | 🟢 | ⚫ | ⚫ |
| Click on the Top Packages table link and check if it redirects to the dashboard with filters and agent pinned | 🟢 | ⚫ | ⚫ |
| Click on the Vulnerability detection panel link and check if it redirects to the dashboard with the agent pinned | 🟢 | ⚫ | ⚫ |
| Check the entire agent's overview responsive layout | 🟢 | ⚫ | ⚫ |
| Change the pinned agent and check if the vulnerability detection panel data change | 🟢 | ⚫ | ⚫ |
Click on Vulnerability KPIs and check if redirects to the dashboard with filters and agent pinned
Grabacion.de.pantalla.2024-10-14.a.la.s.3.56.07.p.m.mov
Click on the Top Packages table link and check if it redirects to the dashboard with filters and agent pinned
Grabacion.de.pantalla.2024-10-14.a.la.s.3.58.32.p.m.mov
Click on the Vulnerability detection panel link and check if it redirects to the dashboard with the agent pinned
Grabacion.de.pantalla.2024-10-14.a.la.s.3.59.55.p.m.mov
Check the entire agent's overview responsive layout
Grabacion.de.pantalla.2024-10-14.a.la.s.4.03.03.p.m.mov
Change the pinned agent and check if the vulnerability detection panel data change
Grabacion.de.pantalla.2024-10-14.a.la.s.4.16.27.p.m.mov
Comment on lines
+85
to
+88
| .then(() => setIsLoading(false)) | ||
| .catch(error => { | ||
| setIsLoading(false); | ||
| }); |
There was a problem hiding this comment.
Suggested change
| .then(() => setIsLoading(false)) | |
| .catch(error => { | |
| setIsLoading(false); | |
| }); | |
| .catch(error => {}) | |
| .finally(() => setIsLoading(false)); |
|
If you haven't set a dataSource, the result is undefined. If you don't have the index or indexPattern, you should handle the error, as the result will be undefined.
|
|
If you have the indexPattern but not the index, the filters are not set. Peek.2024-10-16.10-21.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR, adds the new vulnerability detection card in the agent overview section.
Also, create the necessary components
Closes #7058
Evidence
Screen.Recording.2024-10-09.at.8.25.08.AM.mov
Screen.Recording.2024-10-09.at.8.37.58.AM.mov
Screen.Recording.2024-10-09.at.8.56.58.AM.mov
Test
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Check List
yarn test:jest