Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix maximized visualizations styles #6865

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Fix maximized visualizations styles #6865

merged 4 commits into from
Jul 25, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jul 23, 2024 •
edited
Loading

Description

Fixed the styles when maximising a visualisation as some were too big and others did not occupy the whole screen, the docked menu is taken into account.

Issues Resolved

Evidence

Screen.Recording.2024-07-23.at.4.11.28.PM.mov

Test

  1. Navigate to the different dashboards and test maximising visualisations
  2. Navigate to events and try maximising the displays
  3. They should all be rendered accordingly and should take into account the docked menu or not.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Jul 23, 2024
@yenienserrano yenienserrano linked an issue Jul 23, 2024 that may be closed by this pull request
Full screen visualisations take up more of the screen. #6859
Closed
2 tasks
@yenienserrano yenienserrano mentioned this pull request Jul 23, 2024
Closed
74 tasks
@jbiset jbiset self-requested a review July 23, 2024 15:31
jbiset
jbiset previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI: 🟢

Evidence

evidence.webm

@lucianogorza lucianogorza self-requested a review July 24, 2024 14:41
@lucianogorza
Copy link
Contributor

CR 🟢

Test UI 🟡

Desktop 🟢

desktop.webm

Mobile 🟡

image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.64% ( 3989 / 29237 )
Branches 9.1% ( 1744 / 19153 )
Functions 13.35% ( 943 / 7061 )
Lines 13.82% ( 3886 / 28099 )

@lucianogorza
Copy link
Contributor

Mobile 🟢

image
image

jbiset
jbiset reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile 🟢

THREAT HUNTING

With legend

image

Without legend

image

MITRE

With legend

image

Without legend

image

@lucianogorza lucianogorza merged commit 140812d into 4.9.0 Jul 25, 2024
5 checks passed
@lucianogorza lucianogorza deleted the bug/6859-full-screen-visualisations-take-up-more-of-the-screen branch July 25, 2024 13:19
@asteriscos asteriscos mentioned this pull request Aug 5, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbiset jbiset jbiset approved these changes

@lucianogorza lucianogorza lucianogorza approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full screen visualisations take up more of the screen.
3 participants
@yenienserrano @lucianogorza @jbiset