Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view single document and surrounding documents #6831

Merged
merged 12 commits into from
Jul 26, 2024

Conversation

Machi3mfl
Copy link
Member

Description

This PR adds the view single document and surrounding documents button in flyout details

Closes #6825

Evidence

Screenshot 2024-07-16 at 15 28 57

Test

Check the new view document button in Threat Hunting Dashboard

Screen.Recording.2024-07-16.at.15.23.13.mov

Check the new view document button in Events tab

Screen.Recording.2024-07-16.at.15.23.50.mov

Check the new view document button in Panel tab (GitHub and Office365)

Screen.Recording.2024-07-16.at.15.22.25.mov

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl linked an issue Jul 16, 2024 that may be closed by this pull request
@JuanGarriuz JuanGarriuz self-requested a review July 18, 2024 08:16
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

image
image

When I apply a filter incorrectly, I still get results and two alert messages appear.

image

The filters have not been applied correctly in this search.

image

In the filter manager, there are some functions that I don't know what they are used for, such as enable all, pin, and unpin all, etc.

image

@Machi3mfl
Copy link
Member Author

Test

image image

When I apply a filter incorrectly, I still get results and two alert messages appear.

image

The filters have not been applied correctly in this search.

image

In the filter manager, there are some functions that I don't know what they are used for, such as enable all, pin, and unpin all, etc.

image

@JuanGarriuz, Thanks for your review. That issue does not belong to our scope because it is the OSD Discover.

@yenienserrano
Copy link
Member

Test: 🟢

image image image image

yenienserrano
yenienserrano previously approved these changes Jul 24, 2024
@lucianogorza lucianogorza self-requested a review July 24, 2024 16:12
lucianogorza
lucianogorza previously approved these changes Jul 24, 2024
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

view_buttons.webm

yenienserrano
yenienserrano previously approved these changes Jul 24, 2024
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.63% ( 3989 / 29248 )
Branches 9.1% ( 1744 / 19157 )
Functions 13.36% ( 943 / 7058 )
Lines 13.82% ( 3886 / 28112 )

Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucianogorza lucianogorza dismissed JuanGarriuz’s stale review July 26, 2024 17:58

That issue does not belong to our scope because it is the OSD Discover.

@lucianogorza lucianogorza merged commit 1b3b815 into 4.9.0 Jul 26, 2024
5 checks passed
@lucianogorza lucianogorza deleted the feat/6825-add-view-document-discover branch July 26, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add view single document and surrounding documents buttons
4 participants