Fix wrong cleaned filters when browser back button is triggered #6771

Machi3mfl · 2024-06-13T17:53:56Z

Description

This PR, solves #6762

Evidence

Before

Screen.Recording.2024-06-11.at.14.40.31.mov

After

Screen.Recording.2024-06-14.at.10.35.23.mov

Test

Navigate to the module, switch between tabs and use the browser back button, the fixed filters must not disappear

Screen.Recording.2024-06-14.at.10.48.55.mov

Check flyout discover from inventory or control tab (`MITRE ATT&CK` and all `Security Operations` Menu Options - PCI, GPDR, etc)

Use the filters and check the request filters, must have the filters from the main search bar, hidden filters, and user filters

Screen.Recording.2024-06-14.at.10.38.47.mov

Check the dashboard and discover (Events tab)

Use the filters, pin, and unpin agent and check the request filters, must have the fixed filters, user filters and hidden filters

Dashboard

Screen.Recording.2024-06-14.at.10.52.29.mov

Events

Screen.Recording.2024-06-14.at.10.54.27.mov

Check the Github and Office365 Panel tab

Check the request filters to and pin/unpin agent

Screen.Recording.2024-06-14.at.11.10.11.mov

Check the filters when a row panel is clicked

Screen.Recording.2024-06-18.at.07.56.07.mov

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

- Create basic router - Remove initilization of AngularJS app - Replace AngularJS injector usage by ReactJS

- Create route resolvers - ip - wzConfig - Adapt components to the usage of route resolvers - Fix an error related to circular dependency

- Port route resolvers - getSavedSearch - nestedResolve - savedSearch

- WzAgentSelectorWrapper - ToastNotificationsModal - WzUpdatesNotification

…zuh/wazuh-kibana-app into feat/6680-migrate-app-routing

…he URL

- useRootScope hook - withModuleTabLoader HOC - Dashboard component

…modules

- VisFactoryHandler

- Remove AngularJS services: - DiscoverPendingUpdates - LoadedVisualizations - RawVisualizations - VisHandlers - Remove components: - KibanaVis - ClusterTimelions - KibanaVisWrapper - Metrics - WzVisualize - WzFilterBar

- Remove components - SecurityAlerts

- Redux actions and reducers related to deprecated visualizations

- AngularJS services - DataFactory - region-maps - theming - VisFactoryService - AngularJS filter: orderObjectBy

…erabilities > Inventory based on server API data

- Remove ModulesHelper service - Remove hook: useRefreshAngularDiscover

Desvelao · 2024-06-20T08:07:46Z

Test

🟢 Navigate to the module, switch between tabs and use the browser back button, the fixed filters must not disappear

🟢 Check flyout discover from inventory or control tab (MITRE ATT&CK and all Security Operations Menu Options - PCI, GPDR, etc)
Duplicated filter related to allowed agents:

🟢 Check the dashboard and discover (Events tab)

🔴 Check the Github and Office365 Panel tab
🔴 The filter related to the selection should appear on the selector

See 4.8.0 for compare

JuanGarriuz

Missed Changelog

Machi3mfl · 2024-06-24T16:51:59Z

Fixed bug mentioned by @Desvelao in commit 2e139c0

Screen.Recording.2024-06-24.at.13.38.53.mov

Machi3mfl · 2024-06-24T16:52:24Z

Missed Changelog

Fixed in 03cb3e1

chantal-kelm · 2024-06-25T09:55:57Z

Test

🟢 Navigate to the module, switch between tabs and use the browser back button, the fixed filters must not disappear

Grabacion.de.pantalla.2024-06-25.a.la.s.6.38.36.a.m.mov

🟢 Check flyout discover from inventory or control tab (`MITRE ATT&CK` and all `Security Operations` Menu Options - PCI, GPDR, etc)

Use the filters and check the request filters, must have the filters from the main search bar, hidden filters, and user filters

Grabacion.de.pantalla.2024-06-25.a.la.s.6.50.21.a.m.mov

🟢 Check the dashboard and discover (Events tab)

Use the filters, pin, and unpin agent and check the request filters, must have the fixed filters, user filters and hidden filters

Dashboard

Grabacion.de.pantalla.2024-06-25.a.la.s.6.58.43.a.m.mov

Events

Grabacion.de.pantalla.2024-06-25.a.la.s.7.51.46.a.m.mov

🟢 Check the Github and Office365 Panel tab

Check the request filters to and pin/unpin agent

Grabacion.de.pantalla.2024-06-25.a.la.s.8.14.15.a.m.mov

Check the filters when a row panel is clicked

Grabacion.de.pantalla.2024-06-25.a.la.s.8.29.21.a.m.mov

Desvelao · 2024-06-25T10:13:23Z

Test

Related to Fix wrong cleaned filters when browser back button is triggered #6771 (comment)

…o fix/6762-wrong-cleaned-filters

chantal-kelm

CR: ✅
Test: ✅

github-actions · 2024-06-27T14:38:12Z

Wazuh Core plugin code coverage (Jest) test	%	values
Statements	45.96%	( 399 / 868 )
Branches	41.97%	( 157 / 374 )
Functions	44.01%	( 136 / 309 )
Lines	46.16%	( 397 / 860 )

github-actions · 2024-06-27T14:38:22Z

Wazuh Check Updates plugin code coverage (Jest) test	%	values
Statements	76.44%	( 172 / 225 )
Branches	58.65%	( 61 / 104 )
Functions	61.7%	( 29 / 47 )
Lines	76.44%	( 172 / 225 )

github-actions · 2024-06-27T14:42:30Z

Main plugin code coverage (Jest) test	%	values
Statements	13.64%	( 3989 / 29228 )
Branches	9.1%	( 1744 / 19149 )
Functions	13.35%	( 943 / 7062 )
Lines	13.83%	( 3886 / 28090 )

Desvelao

LGTM!

Desvelao and others added 30 commits May 20, 2024 14:52

feat: migrate router to ReactJS

7085920

- Create basic router - Remove initilization of AngularJS app - Replace AngularJS injector usage by ReactJS

feat(routing): create route resolver HOC

e6312d6

feat(routing): create route resolvers and adapt view components

9bf7732

- Create route resolvers - ip - wzConfig - Adapt components to the usage of route resolvers - Fix an error related to circular dependency

feat(routing): port route resolvers

a0f6f6b

- Port route resolvers - getSavedSearch - nestedResolve - savedSearch

fix(routing): redirection form health check to another route

0b6b136

Angular is removed from PinnedAgentManager and AgentPreview

b931a61

Added history to app router

fd4576e

remove(routing): remove todo comments

f177cfe

fix(routing): adapt listener to remove the API token

604e4e6

fix(routing): add root components

fbfa793

- WzAgentSelectorWrapper - ToastNotificationsModal - WzUpdatesNotification

remove(routing): withReduxProvider from menu component

9436da2

fix(routing): add wazuhNotReadyYet div to the root of the application

c3a7fc7

fix(routing): remove usage of AngularJS injectors

915d862

fix(angularJS): remove usage of AngularJS injectors on Reporting service

eee38c8

Merge branch '4.9.0' into feat/6680-migrate-app-routing

9fc2b2d

fix(routing): add menu to root of the application

ad0ee0a

fix(routing): fix redirection from Endpoints summary to agent view

ce83e29

Merge branch 'feat/6680-migrate-app-routing' of https://github.com/wa…

053078c

…zuh/wazuh-kibana-app into feat/6680-migrate-app-routing

remove: unused Vis2PNG AngularJS factory

6fc6be3

remove: unused VisCard component

d3dbd3c

Navigations Service added to handle navigation and interaction with t…

c179206

…he URL

remove: unused code related to AngularJS

0ad93b8

- useRootScope hook - withModuleTabLoader HOC - Dashboard component

fix(routing): remove usage of AngularJS on main component related to …

2ccf6f4

…modules

remove: unused AngularJS service

4f30588

- VisFactoryHandler

clean: unused code

52c0a98

- Remove AngularJS services: - DiscoverPendingUpdates - LoadedVisualizations - RawVisualizations - VisHandlers - Remove components: - KibanaVis - ClusterTimelions - KibanaVisWrapper - Metrics - WzVisualize - WzFilterBar

clean: unused code

15b235b

- Remove components - SecurityAlerts

clean: remove unused code

7a8c96a

- Redux actions and reducers related to deprecated visualizations

clean: remove unused code

eb00ca5

- AngularJS services - DataFactory - region-maps - theming - VisFactoryService - AngularJS filter: orderObjectBy

clean: remove deprecated view and services related to deprecated Vuln…

960c148

…erabilities > Inventory based on server API data

clean: remove ModulesHelper service

7093191

- Remove ModulesHelper service - Remove hook: useRefreshAngularDiscover

JuanGarriuz reviewed Jun 20, 2024

View reviewed changes

Machi3mfl added 2 commits June 24, 2024 13:46

Fix disabled dropdown when is selected

2e139c0

Update CHANGELOG

03cb3e1

chantal-kelm self-requested a review June 25, 2024 09:31

Merge branch '4.9.0' of https://github.com/wazuh/wazuh-kibana-app int…

339c840

…o fix/6762-wrong-cleaned-filters

chantal-kelm previously approved these changes Jun 25, 2024

View reviewed changes

JuanGarriuz previously approved these changes Jun 26, 2024

View reviewed changes

Move max item per query to global location

7f29967

Machi3mfl dismissed stale reviews from JuanGarriuz and chantal-kelm via 7f29967 June 26, 2024 11:24

Machi3mfl and others added 3 commits June 26, 2024 10:30

Merge branch '4.9.0' into fix/6762-wrong-cleaned-filters

c534774

Merge branch '4.9.0' into fix/6762-wrong-cleaned-filters

9751ea5

fix: unify render of max entries by query on messages

afe01f2

Desvelao requested review from chantal-kelm and JuanGarriuz June 27, 2024 14:17

fix: unify message related to error fetching data of data source

ff58355

Desvelao approved these changes Jun 28, 2024

View reviewed changes

JuanGarriuz approved these changes Jun 28, 2024

View reviewed changes

lucianogorza merged commit f46916b into 4.9.0 Jul 1, 2024
4 checks passed

lucianogorza deleted the fix/6762-wrong-cleaned-filters branch July 1, 2024 12:19

Desvelao mentioned this pull request Jul 1, 2024

The back button displays the login page #6796

Closed

asteriscos mentioned this pull request Aug 21, 2024

Remove embedded discover #6120

Closed

74 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix wrong cleaned filters when browser back button is triggered #6771

Fix wrong cleaned filters when browser back button is triggered #6771

Machi3mfl commented Jun 13, 2024 •

edited

Loading

Desvelao commented Jun 20, 2024 •

edited

Loading

JuanGarriuz left a comment

Machi3mfl commented Jun 24, 2024

Machi3mfl commented Jun 24, 2024

chantal-kelm commented Jun 25, 2024 •

edited

Loading

Desvelao commented Jun 25, 2024

chantal-kelm left a comment

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

Desvelao left a comment

Fix wrong cleaned filters when browser back button is triggered #6771

Fix wrong cleaned filters when browser back button is triggered #6771

Conversation

Machi3mfl commented Jun 13, 2024 • edited Loading

Description

Evidence

Before

After

Test

Navigate to the module, switch between tabs and use the browser back button, the fixed filters must not disappear

Check flyout discover from inventory or control tab (MITRE ATT&CK and all Security Operations Menu Options - PCI, GPDR, etc)

Check the dashboard and discover (Events tab)

Dashboard

Events

Check the Github and Office365 Panel tab

Check List

Desvelao commented Jun 20, 2024 • edited Loading

Test

JuanGarriuz left a comment

Choose a reason for hiding this comment

Machi3mfl commented Jun 24, 2024

Machi3mfl commented Jun 24, 2024

chantal-kelm commented Jun 25, 2024 • edited Loading

Test

🟢 Navigate to the module, switch between tabs and use the browser back button, the fixed filters must not disappear

🟢 Check flyout discover from inventory or control tab (MITRE ATT&CK and all Security Operations Menu Options - PCI, GPDR, etc)

🟢 Check the dashboard and discover (Events tab)

Dashboard

Events

🟢 Check the Github and Office365 Panel tab

Desvelao commented Jun 25, 2024

Test

chantal-kelm left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

github-actions bot commented Jun 27, 2024

Desvelao left a comment

Choose a reason for hiding this comment

Machi3mfl commented Jun 13, 2024 •

edited

Loading

Check flyout discover from inventory or control tab (`MITRE ATT&CK` and all `Security Operations` Menu Options - PCI, GPDR, etc)

Desvelao commented Jun 20, 2024 •

edited

Loading

chantal-kelm commented Jun 25, 2024 •

edited

Loading

🟢 Check flyout discover from inventory or control tab (`MITRE ATT&CK` and all `Security Operations` Menu Options - PCI, GPDR, etc)