Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Build manual Github action #6195

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Update Build manual Github action #6195

merged 1 commit into from
Dec 7, 2023

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Dec 6, 2023 •
edited by Desvelao
Loading

Description

Update the GitHub action for package creation and change the package name to the convention name.

Issues Resolved

Test

  • Run a manual build workflow through dispatching the action

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano requested a review from a team as a code owner December 6, 2023 11:53
@yenienserrano yenienserrano self-assigned this Dec 6, 2023
@yenienserrano yenienserrano linked an issue Dec 6, 2023 that may be closed by this pull request
Update Build GitHub action #6194
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.38% ( 185 / 865 )
Branches 18.07% ( 79 / 437 )
Functions 14.22% ( 36 / 253 )
Lines 21.61% ( 182 / 842 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.95% ( 167 / 217 )
Branches 54.63% ( 53 / 97 )
Functions 60.86% ( 28 / 46 )
Lines 76.95% ( 167 / 217 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Main plugin code coverage (Jest) test % values
Statements 11.87% ( 4184 / 35245 )
Branches 8.14% ( 1927 / 23658 )
Functions 11.24% ( 948 / 8427 )
Lines 12.04% ( 4067 / 33752 )

Desvelao
Desvelao approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Test evidence: https://github.com/wazuh/wazuh-dashboard-plugins/actions/runs/7126940960

@Desvelao Desvelao merged commit 10f26fb into master Dec 7, 2023
7 checks passed
@Desvelao Desvelao deleted the 6194-updating-github-actions-to-be-able-to-use-them-from-other-repositories branch December 7, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Build GitHub action
2 participants
@yenienserrano @Desvelao