-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Periodic logging for additional metrics #1094
Conversation
Additionally, should we log out the metrics using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little nitpicking.
LGTM ✅
Tip: Rebase your branch on top of |
61d4c91
to
0288fa3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Congratulations on your first PR. 🥳 I have added some minor comments on log completion, consistency, etc. If possible, could you add an example log output to this PR to get an idea of how it will look when printed to stdout?
Thanks for your comments, I'll get those changes in tomorrow |
cc: @jm-clius |
0288fa3
to
9dd9f2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! I think this can be merged :)
Should resolve #984
We now log the following fields:
Should the docs mention which fields refer to values over the last reporting period vs since the node setup?