Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "WebTransport session" scoped #308

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

yutakahirano
Copy link
Contributor

@yutakahirano yutakahirano commented Jul 13, 2021

Before this change, #webtransport-session links to
"WebTransport session" and #webtransport-session① links to
"[[Session]]" for="WebTransport.

In order to have a public link to "[[Session]]" at
whatwg/html#6856, add "for=protocol" to
the definition of "WebTransport session".

With this change #protocol-webtransport-session links to
"WebTransport session", and #webtransport-session links to
[[Session]].

This is for #127.


Preview | Diff

Before this change, #webtransport-session links to
"WebTransport session" and #webtransport-session① links to
"[[Session]]" for="WebTransport.

In order to have a public link to "[[Session]]" at
whatwg/html#6856, add "for=protocol" to
the link to "WebTransport session".

With this change #protocol-webtransport-session links to
"WebTransport session", and #webtransport-session links to
[[Session]].
@yutakahirano yutakahirano requested a review from ricea July 13, 2021 12:45
@yutakahirano
Copy link
Contributor Author

@ricea, can you take a look?

Copy link
Contributor

@ricea ricea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yutakahirano yutakahirano merged commit 15bb37d into main Jul 14, 2021
@yutakahirano yutakahirano deleted the yhirano/webtransport-session-slot branch July 14, 2021 05:13
github-actions bot added a commit that referenced this pull request Jul 14, 2021
SHA: 15bb37d
Reason: push, by @yutakahirano

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants