Remove styles #185
Remove styles #185
Conversation
|
The PR does not contain the modified SVG file. PlantUML does not want to generate a nice one on my machine. @nigelmegitt can you add it? |
|
I could not identify from where build error coming... It says html validation failed as:
but with exported html from respec, nu html checker reported no error, nor I could not find title (not |
|
@himorin I think the error is due to the SVG file referring to some sections of the spec that have been removed. Once the SVG is regenerated (my request to Nigel, above), that should be fine. |
|
Will do! |
|
Done, and the checks passed this time, confirming @cconcolato's hypothesis. |
Also pre-emptively remove the Style assuming that #185 is approved too. If not, will need to re-instate Style.
* Split Script Event Description out as a separate object Closes #174. Clarifies the cardinality of Script Event Description. Updates the data model diagram (in a way that is non-ideal but hard to fix automatically: it may be worth replacing the PlantUML-generated diagram with a more manually constructed one prior to final publication), and defines Description Type more explicitly. Also clarify that there is no uniqueness constraint for `daptm:descType` and that `xml:lang` can be used to label the language of the contents of a `ttm:desc`. * Add optional language to script description in UML model Also pre-emptively remove the Style assuming that #185 is approved too. If not, will need to re-instate Style. * Address review feedback * typos and minor editorial tweaks
nigelmegitt
force-pushed
the
style_removal
branch
from
69ffcb3
to
2f004cc
Compare
Co-authored-by: Nigel Megitt <[email protected]>
nigelmegitt
force-pushed
the
style_removal
branch
from
2f004cc
to
b16db46
Compare
Close #124
Close #162
Preview | Diff