Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add explicit nuxt alias for nuxt3 #781

Closed
wants to merge 2 commits into from

Conversation

tobiasdiez
Copy link

The explicit nuxt alias leads to problems with nuxt/bridge (using vite) as descirbed here #690 (comment).
I'm not completely sure why this alias was added in the first place. Since pinia is added to build.transpile anyway, the es module build shouldn't be used anyway.

Reverts 438b16d
Fixes #690.

The explicit nuxt alias leads to problems with nuxt/bridge (using vite) as descirbed here vuejs#690 (comment).

Reverts vuejs@438b16d
Fixes vuejs#690.
@tobiasdiez tobiasdiez mentioned this pull request Nov 7, 2021
38 tasks
@tobiasdiez tobiasdiez changed the title Remove explicit nuxt alias Only add explicit nuxt alias for nuxt3 Nov 9, 2021
@posva
Copy link
Member

posva commented Dec 22, 2021

Thanks for the PR, I tested it and it seems not to be enough as it yields

Error: [vue-composition-api] must call Vue.use(VueCompositionAPI) before using any function.

@tobiasdiez
Copy link
Author

Maybe it's a good idea to wait until #791 is merged? @pi0 what do you think?

@tobiasdiez
Copy link
Author

With the new version of the nuxt module, everything is working fine and this PR is no longer necessary.

@tobiasdiez tobiasdiez closed this Jul 14, 2022
@tobiasdiez tobiasdiez deleted the patch-1 branch July 14, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuxt.js 2 + nuxt-vite + pinia error
2 participants