Use Site PHP Version to Run Composer Install #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devsarfo VitoDeploy doesn't set that kinda aliases for PHP binary. 
|
|
@saeedvaziry The change uses the php_version from the Site Model as shown below. The version would be 8.2 instead of 82 and the command would run as shown below |
|
@devsarfo oh my bad. thats cool tnx |
saeedvaziry
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @maxcelos When creating a new site with the "Run composer install --no-dev" flag, it runs with the default PHP CLI, ignoring the PHP version selected in the form. It should use the selected PHP version.
This should pass the php_version to the getScript function to be used in the composer-install.sh