Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to express 5 #18537

Merged
merged 4 commits into from
Nov 5, 2024
Merged

chore: upgrade to express 5 #18537

merged 4 commits into from
Nov 5, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 31, 2024

Description

Update to express 5, but keep docs in v4 because v4 is still marked latest in npm. I'm happy to close this too if we want to keep testing against v4 to match the docs.

This should resolve #18234

sapphi-red
sapphi-red previously approved these changes Nov 1, 2024
docs/package.json Outdated Show resolved Hide resolved
@sapphi-red sapphi-red added dependencies Pull requests that update a dependency file p1-chore Doesn't change code behavior (priority) labels Nov 1, 2024
sapphi-red
sapphi-red previously approved these changes Nov 1, 2024
@patak-dev patak-dev added this to the 6.0 milestone Nov 5, 2024
@bluwy bluwy merged commit ce0eec9 into main Nov 5, 2024
15 checks passed
@bluwy bluwy deleted the express-5 branch November 5, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants