Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't fail on routes that begin with the page base setting #546

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andyburke
Copy link
Contributor

This resolves an issue where if you set the base to something that matches the beginning of one of your routes, things will not work properly. Eg:

page.base( '/en' ); // set to english localization

If you have a route like '/enroll', this will cause errors.

This change fixes the issue.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.531% when pulling 35e8c5f on andyburke-forks:base_fix into 0d7e127 on visionmedia:master.

@coveralls
Copy link

coveralls commented Nov 14, 2019

Coverage Status

Coverage remained the same at 92.531% when pulling 05a745d on andyburke-forks:base_fix into 0d7e127 on visionmedia:master.

@matthewp
Copy link
Collaborator

Thanks for adding a test!

It looks like compiling made a whole bunch of changes that were related to your change. Why is that?

@andyburke
Copy link
Contributor Author

I honestly don't know. I just tried re-running npm install to see if I somehow have a different version of whatever libraries are used to compile, but I don't think I do.

Is there a way you could pull the branch and try to build and see if the same thing is happening?

@matthewp
Copy link
Collaborator

matthewp commented Dec 4, 2019

Yeah I can do that, probably not until this weekend though.

@andyburke
Copy link
Contributor Author

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants