Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing features #473

Merged
merged 14 commits into from
Feb 2, 2024
Merged

Add missing features #473

merged 14 commits into from
Feb 2, 2024

Conversation

marcoeilers
Copy link
Contributor

@marcoeilers marcoeilers commented Oct 28, 2023

@marcoeilers marcoeilers marked this pull request as ready for review January 21, 2024 20:18
@marcoeilers
Copy link
Contributor Author

  • forperm is often incomplete, but this is due to triggering. I don't know what better triggers one could choose than { Mask[r, f] } and { Heap[r, f] }, so I don't think we can do anything about that.
  • Resource triggers are also often incomplete. The trigger { x.f } is currently translated as { Heap[x, f] }, so it does not trigger at all on mask accesses. That seems bad to me and would be easy to fix.

Copy link
Contributor

@gauravpartha gauravpartha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I just added some minor comments, but looks good to me otherwise.

@marcoeilers marcoeilers dismissed gauravpartha’s stale review February 2, 2024 13:26

Addressed all comments

@marcoeilers marcoeilers merged commit 28e12c0 into master Feb 2, 2024
1 check passed
@marcoeilers marcoeilers deleted the meilers_general_perm_forperm branch February 2, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants