Improve getinfo
#203
Merged
Improve getinfo
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincenzopalazzo
requested changes
Apr 5, 2024
Harshit933
force-pushed
the
feat/getinfo
branch
2 times, most recently
from
7164c34
to
7db08c1
Compare
vincenzopalazzo
requested changes
Apr 7, 2024
vincenzopalazzo
requested changes
Apr 9, 2024
| @@ -213,6 +215,8 @@ impl TryFrom<String> for LampoConf { | |||
| _ => "info".to_string(), | |||
| }; | |||
| let log_file = conf.get_conf("log-file").unwrap_or_else(|_| None); | |||
| let alias = conf.get_conf("alias").unwrap_or(None); | |||
There was a problem hiding this comment.
we need to announce this, but looks like I still need to finish some work here #202
Lets open a issue and keep track of this
There was a problem hiding this comment.
I don't get it. Why do we need to announce alias? Is this related to bolt12?
There was a problem hiding this comment.
I don't get it. Why do we need to announce alias? Is this related to bolt12?
we need to announce to the network with a node announcement, it is not related to bolt12, but I did some of the work on the PR that support the bolt12
Shows the warnings related to the bitcoin core node. Update: The warnings of core should not be shown inside `getinfo`. Thus removed it.
Harshit933
force-pushed
the
feat/getinfo
branch
from
4cbcb90
to
36c03c2
Compare
vincenzopalazzo
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
ACK 36c03c2
P.S: remember to open the issue with the alias announcement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future fix #192
aliasblockheightlampo_dir