Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getinfo more awesome #192

Open
Harshit933 opened this issue Mar 10, 2024 · 8 comments · Fixed by #203
Open

Make getinfo more awesome #192

Harshit933 opened this issue Mar 10, 2024 · 8 comments · Fixed by #203
Assignees
Labels
❤️ - pre-SoB Prerequisity of the Summer of Bitcoin mini project 🦀 - rust Rust related things enhancement New feature or request P-low Low priority issue
Milestone

Comments

@Harshit933
Copy link
Collaborator

As discussed on discord, we should add more information about the node inside getinfo. Make it similar to the core-lightning implementation.

@Harshit933 Harshit933 added enhancement New feature or request 🦀 - rust Rust related things labels Mar 10, 2024
@vincenzopalazzo vincenzopalazzo added the ❤️ - pre-SoB Prerequisity of the Summer of Bitcoin mini project label Mar 11, 2024
@vincenzopalazzo vincenzopalazzo added this to the v24.03 milestone Mar 11, 2024
@vincenzopalazzo
Copy link
Owner

Moving this to the next release in june

@vincenzopalazzo vincenzopalazzo modified the milestones: v24.03, v24.06 Mar 30, 2024
@Harshit933
Copy link
Collaborator Author

Moving this to the next release in june

I did some work on this. Will put up a PR tomorrow.

@vincenzopalazzo
Copy link
Owner

uuh amazin, lets see if we can include it inside this release because I am a little bit in delay

@vincenzopalazzo
Copy link
Owner

This is not finished @Harshit933

Are you able to add the address specified by the user inside the getinfo response?

Currently we do not know where the node is listening, if it is listening somewhere

@Harshit933
Copy link
Collaborator Author

@vincenzopalazzo can we close this?

@vincenzopalazzo
Copy link
Owner

The response is reach like the core lightning one? I do not thing so

Why you want to close it?

@Harshit933
Copy link
Collaborator Author

I thought #229 were the final steps for the issue.

@vincenzopalazzo
Copy link
Owner

I thought #229 were the final steps for the issue.

With code there is never a final step, but the get info needs more love anyway. The core lightning one is more complete https://docs.corelightning.org/reference/lightning-getinfo#synopsis

@vincenzopalazzo vincenzopalazzo added the P-low Low priority issue label May 30, 2024
@vincenzopalazzo vincenzopalazzo modified the milestones: v24.06, v24.08 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❤️ - pre-SoB Prerequisity of the Summer of Bitcoin mini project 🦀 - rust Rust related things enhancement New feature or request P-low Low priority issue
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants