Skip to content

Commit

Permalink
Merge pull request #4303 from xchang1/fix-lr-params
Browse files Browse the repository at this point in the history
Fix command line downsmapling parameters to match what they're doing
  • Loading branch information
xchang1 authored Jun 3, 2024
2 parents 8e13416 + b939bfb commit 4ee2592
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/subcommand/giraffe_main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -184,16 +184,16 @@ static std::unique_ptr<GroupedOptionGroup> get_options() {
"use maximum of number minimizers calculated by READ_LENGTH / INT and --max-min"
);
comp_opts.add_range(
"downsample-window-count",
"downsample-window-length",
&MinimizerMapper::minimizer_downsampling_max_window_length,
MinimizerMapper::default_minimizer_downsampling_max_window_length,
"downsample minimizers with windows of length read_length/INT, 0 for no downsampling"
"maximum window length for downsampling"
);
comp_opts.add_range(
"downsample-window-length",
"downsample-window-count",
&MinimizerMapper::minimizer_downsampling_window_count,
MinimizerMapper::default_minimizer_downsampling_window_count,
"maximum window length for downsampling"
"downsample minimizers with windows of length read_length/INT, 0 for no downsampling"
);
comp_opts.add_range(
"distance-limit", 'D',
Expand Down

1 comment on commit 4ee2592

@adamnovak
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vg CI tests complete for branch lr-giraffe. View the full report here.

0 tests passed, 16 tests failed and 0 tests skipped in 519 seconds

Failed tests:

  • test_sim_chr21_snp1kg (35 seconds)
  • test_full_brca2_cactus (32 seconds)
  • test_full_brca2_primary (30 seconds)
  • test_full_brca2_snp1kg (31 seconds)
  • test_map_brca1_cactus (30 seconds)
  • test_map_brca1_primary (30 seconds)
  • test_map_brca1_snp1kg (30 seconds)
  • test_map_brca1_snp1kg_mpmap (30 seconds)
  • test_map_mhc_primary (30 seconds)
  • test_map_mhc_snp1kg (30 seconds)
  • test_sim_mhc_cactus (27 seconds)
  • test_sim_mhc_snp1kg (34 seconds)
  • test_sim_mhc_snp1kg_mpmap (35 seconds)
  • test_call_chr21_snp1kg (28 seconds)
  • test_sim_chr21_snp1kg_trained (36 seconds)
  • test_sim_yeast_cactus (30 seconds)

Please sign in to comment.