Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialized variables #966

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

visuve
Copy link

@visuve visuve commented Sep 2, 2022

  • Found them using Cppcheck

@alt3r-3go
Copy link
Contributor

@visuve, looks like the bugfix part should now be removed after that "New sync wizard" piece with sizeof() bug was reverted, to also resolve the PR branch conflicts with master.

@visuve
Copy link
Author

visuve commented Jan 8, 2023

@alt3r-3go okay, thanks for mentioning! I will fix the uninitialized variable issues later.

Btw, can I use C++11 or greater?

@alt3r-3go
Copy link
Contributor

This is not strictly codified in the docs I think, but the Linux makefile uses gnu++14 (while explicitly mentioning 17 won't work) and the macOS one uses c++11. Haven't checked the Windows setting, but in view of the above 11 should be ok, yes. @idrassi, please chime in if you have any better definition here.

@visuve
Copy link
Author

visuve commented Jan 18, 2023

@alt3r-3go I rebased the changes and used C++11 style initialization.

I think there is quite much to do to modernize the code base to C++11 (or greater), but I'm willing to help with small PRs.

@visuve visuve changed the title Fix bug & uninitialized variables Fix uninitialized variables Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants