Turn Jently into a daemon. Distributed it as a RubyGem. #40
Conversation
- Adjust requires to source from jently/ - Add some very basic option parsing - Rename the logger we're using
…fine class methods
…t telling the user
|
brilliant. I'll merge it over the weekend. Way too busy with work atm 😢 |
- Make variable names clearer - Use debug logging - Use more idiomatic Ruby looping - Make log messages clearer
- Simplify variable names - Make setting pull request status less cluttered - Add logging - Simplify conditionals
|
Actually you should hold off. 😞 We've been having issues with this in production the last few days, and I'm doing some refactoring around the place to improve the logging and get a better understanding of why builds are being constantly triggered. 💩 |
|
OK, I made a whole bunch of logging improvements to attempt to make Jently's behaviour more transparent. 🔍 I've got it working and we haven't had issues with builds being triggered infinitely the last few days. ➿ Just noticed that the Travis build is failing, so I'll need to check what is going on there. 😞 |
|
yay \o/ 😢 (for the failing build) |
|
💩 |
|
@jesseadams anything that's particularly 💩? |
|
@auxesis - Just the fact that this PR lost momentum 😸 |
|
That's life, I guess. 💀 We've actually been running this in production for a few months at @bulletproofnetworks and it's working pretty great. I just need to work out why the tests are failing on Travis. |
|
😢 |
Fixes #34.
Per #34, the main benefits of this PR are:
gem install jently+ setup a config file + start the Jently daemon.There's a lot of changes to digest, so I'm looking forward to any feedback you have.
I didn't tackle a full on refactoring of Jently as I wanted to keep as much of Jently the same as possible. I may submit another PR in the next few weeks to make the code a little more consistent.
@vaneyckt once you sign off on the PR and merge, you can do the honours of releasing to RubyGems.org.