Migrate valyala/tcplisten to this repo #1926 #1929
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CP backlog size update of uint16->uint32 with Linux
…rt for dual-stack socket
…oroutine as the test
ksw2000
force-pushed
the
fix-issue-1926
branch
from
700e617 to
75a611b
Compare
|
I think the error is caused by |
|
@ksw2000 Can these be added too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1926
This PR moves the valyala/tcplisten package to fasthttp and also migrates PR#6 and PR#10 together. Additionally, it upgrades the deprecated
ioutilpackage and replaces the+builddirective withgo:build. Furthermore, it fixes the warning intcplisten_test.goregarding "the goroutine calls T.Fatalf, which must be called in the same goroutine as the test".