Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add typed arrays #428

Closed
wants to merge 2 commits into from
Closed

perf: add typed arrays #428

wants to merge 2 commits into from

Conversation

iiio2
Copy link
Contributor

@iiio2 iiio2 commented Aug 11, 2024

Typed Arrays are added for retryStatusCodes and nullBodyResponses. I think may be typed arrays are considered more memory efficient.

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.82%. Comparing base (27996d3) to head (659c607).
Report is 33 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #428       +/-   ##
===========================================
+ Coverage   56.86%   69.82%   +12.95%     
===========================================
  Files          16       15        -1     
  Lines         728      613      -115     
  Branches      113      115        +2     
===========================================
+ Hits          414      428       +14     
+ Misses        303      175      -128     
+ Partials       11       10        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi0
Copy link
Member

pi0 commented Aug 27, 2024

Thank you for the PR but i think in this case simplicity values more. (unless we can prove with benchmarks the check performance will be significantly different)

@pi0 pi0 closed this Aug 27, 2024
@iiio2 iiio2 deleted the iiio2/patch-19478 branch September 1, 2024 17:44
@iiio2
Copy link
Contributor Author

iiio2 commented Sep 1, 2024

Ok @pi0 . Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants