Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #57

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Update dependencies #57

merged 1 commit into from
Aug 22, 2023

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This makes it compatible with unified 11 and unified-engine 11.

This makes it compatible with unified 11 and unified-engine 11.
@remcohaszing remcohaszing added 📦 area/deps This affects dependencies 🗄 area/interface This affects the public interface 🧑 semver/major This is a change 🤞 phase/open Post is being triaged manually labels Aug 19, 2023
.prettierignore Show resolved Hide resolved
lib/index.js Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might also support ancestors: https://github.com/vfile/vfile-message#fields

lib/index.js Show resolved Hide resolved
@remcohaszing
Copy link
Member Author

I looked into ancestors, but I think the information is not relevant here. It makes the messages very verbose. As an end user of the language server, the fact that everything is based on ASTs, is an implementation detail.

@wooorm
Copy link
Member

wooorm commented Aug 19, 2023

I’m not saying it should be a default. It isn’t in vfile-reporter either.

But I see if quite different. There are many reasons for errors to be thrown. I think users and the code that emits errors should decide whether the positional info and other info in the AST is an “implementation detail” or not.

@remcohaszing
Copy link
Member Author

remcohaszing commented Aug 22, 2023

I created #60 to track the feature to add ancestor traces. It would be nice to have #43 first, since that sets up a configuration option already, making it simpler to add a new one later.

@remcohaszing remcohaszing merged commit 752400a into main Aug 22, 2023
13 checks passed
@remcohaszing remcohaszing deleted the update-dependencies branch August 22, 2023 09:38
@github-actions

This comment has been minimized.

@remcohaszing remcohaszing added the 💪 phase/solved Post is done label Aug 22, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies 🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧑 semver/major This is a change
Development

Successfully merging this pull request may close these issues.

2 participants