Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2444] Fix RST scenario violation in H2 #1663

Closed
wants to merge 1 commit into from
Closed

[UNDERTOW-2444] Fix RST scenario violation in H2 #1663

wants to merge 1 commit into from

Conversation

baranowb
Copy link
Contributor

@baranowb baranowb commented Sep 19, 2024 •
edited
Loading

@baranowb baranowb added bug fix Contains bug fix(es) under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check backport The PR is the result of backporting another PR to a maintainance branch waiting peer review PRs that edit core classes might require an extra review labels Sep 19, 2024
This was referenced Sep 19, 2024
Closed
Merged
rhusar
rhusar suggested changes Sep 29, 2024
View reviewed changes
core/src/main/java/io/undertow/protocols/http2/Http2Channel.java
@@ -1378,6 +1380,10 @@ private static final class StreamHolder {
* This flag is set only in case of short lived server push that was reset by remote end.
*/
boolean resetByPeer = false;
/**
* flag indicate whether our side originated. This is done for caching purposes, handlng differs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/handlng/handling

core/src/main/java/io/undertow/protocols/http2/Http2Channel.java
Comment on lines +1421 to +1423
* Method will return only sent
* @param streamId
* @return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This Javadoc needs to be improved, it's really not clear what is meant here.

@fl4via
Copy link
Member

fl4via commented Oct 4, 2024

@baranowb I'm closing this PR so we can backport in bulk, to avoid overusing CI resources and to follow the procedure we have for the Undertow backport of PRs

@fl4via fl4via closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhusar rhusar rhusar requested changes

@jasondlee jasondlee Awaiting requested review from jasondlee

@ropalka ropalka Awaiting requested review from ropalka

Assignees
No one assigned
Labels
backport The PR is the result of backporting another PR to a maintainance branch bug fix Contains bug fix(es) under verification Currently being verified (running tests, reviewing) before posting a review to contributor waiting CI check Ready to be merged but waiting for CI check waiting peer review PRs that edit core classes might require an extra review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@baranowb @fl4via @rhusar