Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-2289] limit SavedRequest's buffer allocation to the request length #1500

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-2289] limit SavedRequest's buffer allocation to the request length #1500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions servlet/src/main/java/io/undertow/servlet/util/SavedRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ public static void trySaveRequest(final HttpServerExchange exchange) {
UndertowLogger.REQUEST_LOGGER.debugf("Request to %s was to large to save", exchange.getRequestURI());
return;//failed to save the request, we just return
}
// we don't need to size the buffer larger than a known request length
if (requestContentLength > 0) {
maxSize = (int) requestContentLength;
}
//TODO: we should really be used pooled buffers
//TODO: we should probably limit the number of saved requests at any given time
byte[] buffer = new byte[maxSize];
Expand Down
Loading