Feat/dt 1927 Adding GA4 server side #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-leggett
force-pushed
the
feat/dt-1927-cookie-banner
branch
3 times, most recently
from
ffe4b3d
to
642831e
Compare
ian-leggett
changed the title
ian-leggett
force-pushed
the
feat/dt-1927-cookie-banner
branch
from
642831e
to
e953584
Compare
ian-leggett
force-pushed
the
feat/dt-1927-cookie-banner
branch
from
e953584
to
c18fbab
Compare
ian-leggett
commented
Jun 21, 2024
ian-leggett
force-pushed
the
feat/dt-1927-cookie-banner
branch
from
21ff6c3
to
0e7dcdc
Compare
michalc
force-pushed
the
feat/dt-1927-cookie-banner
branch
9 times, most recently
from
1b1a2f9
to
dea0064
Compare
This adds GA4 server-side analytics using the GA4 measurement protocol, similar to the UA measurement protocol already in place. Both will be run at the same time for now as GA4 is tested - and there may well be more changes to the GA4 server-side analytics in the next week or so. Note that server-side is fairly important because the primary function of the public-data-api is the API (which includes data download), which do not have web pages in front of them to run client-side analytics. Co-authored-by: Ian Leggett <[email protected]> Co-authored-by: Michal Charemza <[email protected]>
michalc
force-pushed
the
feat/dt-1927-cookie-banner
branch
from
dea0064
to
c850421
Compare
michalc
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes adds the GA4 server side.
I am keeping the old implementation for two reasons: