Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Needle dynamic codepath #436

Merged
merged 2 commits into from
Aug 29, 2022
Merged

New Needle dynamic codepath #436

merged 2 commits into from
Aug 29, 2022

Conversation

rudro
Copy link
Collaborator

@rudro rudro commented Aug 19, 2022

@rudro rudro requested a review from wbond August 19, 2022 05:52
@wbond
Copy link
Collaborator

wbond commented Aug 19, 2022

Looks like we'll need at least Xcode 13 on CI. I'll send a PR in a little while.

@wbond
Copy link
Collaborator

wbond commented Aug 19, 2022

I have #437 up to hopefully fix the CI

- Code generated is guarded so current behavior is not affected
- Both paths are generated in the same file, the parsing of the `#if` should not slow things down
- Addresses #432
Copy link
Collaborator

@ryanaveo ryanaveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rudro rudro merged commit c80fbc1 into master Aug 29, 2022
@rudro rudro deleted the rudro_trim branch August 29, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants