Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReportableScope interface for use with pull interface #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Intar
Copy link

@Intar Intar commented Aug 13, 2018

You can use ReportableScope if you need to send data after some event happened.
For example, you can use this interface in HTTP Handler for pull-based metrics model.

@CLAassistant
Copy link

CLAassistant commented Aug 13, 2018

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

coveralls commented Aug 13, 2018

Coverage Status

Coverage decreased (-0.7%) to 93.619% when pulling 9d72177 on Intar:master into d0a004a on uber-go:master.

@robskillington
Copy link
Contributor

@mway thoughts on this? Expanding the API scope is probably not ideal, wonder if there's a similar way to support this without creating another interface.

@mway
Copy link
Member

mway commented May 15, 2019

@mway thoughts on this? Expanding the API scope is probably not ideal, wonder if there's a similar way to support this without creating another interface.

agreed - we want scope convergence, not divergence. most of these types of problems can be solved outside of the API layer.

for example, we could hooks to the config struct and internalize it, but we'd need to bench the impact of adding hook evaluations (even noops) to the hot path. we shouldn't create use-case-specific hooks/callbacks, though - this should be solved generally.

will be gathering all of these types of use cases (this isn't altogether dissimilar from context baggage extraction that we've been talking about) as part of the conversations around making changes to the API.

it'd also be helpful to understand the impact so that we can prioritize accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants