-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP provide params to invoke #215
base: master
Are you sure you want to change the base?
Conversation
I noticed this in the README, though I don't really understand why dig would be bad for this nor is there anything I can find in the go space that would be better for it. |
Responded about the feature itself in #214.
The pattern we want to discourage is making the container available to the Something like,
One of the major disadvantages of something like this is that your Further, that's just a step removed from something like,
Which, in addition to having the same problems as the other case, is going to |
you're saying significantly slower, but benchmarking dig shows its ~1500ns for a provide, that's not that bad ... |
|
Would it be an idea to let
Invoke
take arguments that aren't coming from the container?It seems rather straight forward to add this, which leads me to belief it's not in there for a (good) reason...?
I understand this PR would break BC and it would be better to have a new method, but opening the pR atm purely for discussion as it's also missing any tests atm so it's not ready to be merged anyway.
If there's interest in merging it then I'll add
InvokeWithParam
or smt and add tests.would be used something like;