Пришлось немного подредактировать application.yml из-за того, что pos… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tgre не нравились имя базы данных и пользователя.
| url: jdbc:postgresql://localhost:5432/home-budget | ||
| username: user | ||
| password: myPass | ||
| url: jdbc:postgresql://localhost:5432/homebudget |
There was a problem hiding this comment.
Ну с такой правкой оно уже у меня не будет работать :-)
Это выглядит как правка, которая важна только для вашего окружения. Такие вещи лучше не коммитить, по крайней мере, в глобальный файл application.yaml. Для таких целей можно сделать свой собственный application-debug.yaml, внести свои специфичные правки уже в него и запускать приложение с профилем debug.
typeundefined
requested changes
Nov 29, 2018
| * @author Trokhin | ||
| * | ||
| */ | ||
| public interface ICategoryService { |
There was a problem hiding this comment.
Пока что интерфейс выглядит излишним. Хотя, конечно, так тоже можно.
| public CategoryDTO getByID(@PathVariable("id") Long id) { | ||
| CategoryDTO categoryDTO = categoryService.get(id); | ||
|
|
||
| if(categoryDTO == null) |
There was a problem hiding this comment.
Не проще ли бросить exception сразу из сервиса? Всегда проще работать в предположении, что сервис не вернул null (ибо что с ним делать-то?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tgre не нравились имя базы данных и пользователя.