Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zigzag indicator added to resolve issue #443 #691

Closed
wants to merge 1 commit into from
Closed

zigzag indicator added to resolve issue #443 #691

wants to merge 1 commit into from

Conversation

aligheshlaghi97
Copy link

Developed zigzag indicator to resolve #443

@twopirllc
Copy link
Owner

Hello @aligheshlaghi97,

Awesome! Would it be possible to checkout the development branch and add it there in a new PR? If not, I will port to the development branch.

Thanks,
KJ

@aligheshlaghi97
Copy link
Author

Hey there @twopirllc
I tried to do so but I couldn't. Actually I didn't fork 'development' branch. Can you please help me to do it?
I think I should delete the repo I forked and try to fork again to contain development branch and then I can add the code to it. Am I right?

@twopirllc
Copy link
Owner

Yo @aligheshlaghi97

To be honest, I am not as proficient with git as I probably should be. I use Github Desktop to help me manage my repos.

I haven't tried the Github web feature to Add File button but that may be a place to start after navigating to the development branch. Also just found this on how to contribute, hopefully that helps.

Don't worry if you can't do it.

KJ

@aligheshlaghi97 aligheshlaghi97 closed this by deleting the head repository May 30, 2023
@aligheshlaghi97
Copy link
Author

aligheshlaghi97 commented May 30, 2023

Thanks @twopirllc for your response,

As far as I searched, there were no other ways to keep this fork while I didn't have access to development branch. So I decided to remove this fork, create another one which includes development branch.

I will update the code and make another PR asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zig Zag Indicator
2 participants