Fixing ALMA calculation per Issue 455

[jaggas]

#455

[twopirllc]

Hello @jaggas,

Curious if you seen Issue #373. I revamped it then but it is on the development branch if you want to give it a spin.

$ pip install -U git+https://github.com/twopirllc/pandas-ta.git@development

Let me know what you think. If you want to add another version, we can do that also.

Kind Regards,
KJ

[jaggas]

Wow, I looked over the issues and completely missed that one somehow. I'll check it out and get back with you tommorrow.

Thanks,
Jeff

[jaggas]

Ok, so just compared your implementation with mine. I attached a csv with output from both versions. Delta between the values is negligable (<0.01%). So I'd say to take your changes addressing #373. Your code is very efficient - nicely done. I'll have to check out whatever tricks you played with numpy.
alma_comparison.csv

[twopirllc]

Hi @jaggas,

Thank you! Not gonna lie, it took some time to figure out. Wish all of them could be that fast and compact.

I do appreciate that you took the initiative to code a solution instead of letting it sit in the Issue pile. If alma wasn't too difficult, perhaps you might want to try your hand at a few other Good First Issue indicators that I haven't been able to work on yet. 😎 If it's a new Indicator, I recommend following Creating a Custom Indicator: The Big 4 #355.

Kind Regards,
KJ

[jaggas]

@twopirllc, Sure thing, I'll take a look at those and pick one to work on.

Thanks,
Jeff