Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zig Zag Indicator #443

Closed
AureliusMarcusHu opened this issue Nov 29, 2021 · 5 comments
Closed

Zig Zag Indicator #443

AureliusMarcusHu opened this issue Nov 29, 2021 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@AureliusMarcusHu
Copy link

Hi,
pandas_ta is a fantastic project, thanks for sharing it.

Maybe it si a good idea to implement the Zig-Zag indicator.
It is a indicator that is nog based on periods but on % of change.
On this way will be easy to find the higest and lowest pivot points in the past.
It is also great to see the trend is up or down.
In the link below the indicator is explained:
https://www.investopedia.com/terms/z/zig_zag_indicator.asp

@AureliusMarcusHu AureliusMarcusHu added the enhancement New feature or request label Nov 29, 2021
@twopirllc twopirllc added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 30, 2021
@twopirllc twopirllc removed their assignment Nov 30, 2021
@twopirllc
Copy link
Owner

Hello @AureliusMarcusHu,

It's on the list. Hopefully someone can help contribute so it can be added quicker. 😎

Kind Regards,
KJ

@puneeth714
Copy link

Did anyone working on Zig Zag indicator ?

@twopirllc
Copy link
Owner

Hello @puneeth714,

No one has submitted a working PR with it implemented yet. If you are feeling up to it, see #355 Creating a Custom Indicator on how to integrate it. Your contribution would be greatly appreciated. 😎

Thanks,
KJ

@jonathandumaresq
Copy link

Not a direct code, but I use this once for a project and look to be working great. Maybe a start ?

https://github.com/djoffrey/HarmonicPatterns

@aligheshlaghi97
Copy link

aligheshlaghi97 commented May 27, 2023

Hi there!
That's an honor for me using pandas-ta library regularly and this motivated me to participate in its development. I developed zigzag indicator to resolve this issue.
If there was any problems or feedback about it, please do not hesitate to get in touch as I always love to learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants