DO NOT MERGE: fast-binary-sort adds TBase OrderedSerialization #1212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #1210 only merge after that has been merged.
Tasks:
Array[Byte]
due to string compare effectively being unsigned, butArray[Byte]
/ByteBuffer comparison being signed we need to be careful about the OrderedSerialization contract. We should do our best to find a high performance way to follow the laws.