Skip to content
This repository has been archived by the owner on Nov 13, 2021. It is now read-only.

Rails 4 compatibility #92

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rails 4 compatibility #92

wants to merge 4 commits into from

Conversation

changok
Copy link

@changok changok commented Jan 14, 2016

  1. In spec, expecting by .raise_error without error type is deprecated as it can cause false positive. So, I added expected error types and replace unnecessary error expectation to attribute checks
  2. In Rails4, there's no difference between .scoped and .all. Both returns active relation. In doing so, we don't need to specify find_scope any more for FinderMethods methods. Also the existing behavior for it doesn't give us any benefit. It just calls the scope at the end of query result.

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants