feat(csrf) enable csrf token in other way than ruby's one #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add two otpions - upload-options-csrf-param name of the hidden parameter added to the form - upload-options-enable-csrf enable csrf in a simpler manner than ruby's one by getting token in cookie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here is a PR to allow csrf in an other way than rail's one. In angular > 1.2 we can configure csrf cookie name and cookie header to let angular read the cookie and add token in headers. The idea here is to act as similar way instead of using meta tags
Add two options
Please let me know your opinion on this new feature.
Thx
Colin