This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
[v1] Panels are cards now #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice PR @Herst ! 👏 |
Johann-S
approved these changes
Sep 23, 2018
Herst
force-pushed
the
next
branch
2 times, most recently
from
622ae8b
to
65d8daf
Compare
Herst
force-pushed
the
next-panels-are-cards-now
branch
from
a83e801
to
63a44b5
Compare
Herst
changed the title
Herst
force-pushed
the
next-panels-are-cards-now
branch
2 times, most recently
from
b64ad9b
to
0eec84e
Compare
Herst
force-pushed
the
next-panels-are-cards-now
branch
from
0eec84e
to
cec94a8
Compare
Herst
force-pushed
the
next
branch
2 times, most recently
from
dd8c5f2
to
0258293
Compare
Port E023, E024, E025, and E026
Herst
force-pushed
the
next-panels-are-cards-now
branch
from
cec94a8
to
c09effd
Compare
66 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port E023, E024, E025, and E026
Basically the changes mentioned at https://getbootstrap.com/docs/4.1/migration/#panels but also the fact that
.carddoes not need to be a direct parent anymore and also can be directly combined with.card-bodyon the same element (I can't remember what made me think that latter applies though, it has been a year).What could be added in the future are tests for
.card-group/.card-deck/.card-columnsand making sure that.card-title/.card-subtitleare added to a<h*>and.card-linkto<a>elements (#424)..card-bodyand.cardis really a good idea and I still don't remember where I got the idea that it might be.