This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 313
[v1] Adapt for input group changes #423
Open
Herst
wants to merge
1
commit into
next
Choose a base branch
from
next-input-group
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herst
changed the title
Adapt for input group changes
[v.next] Adapt for input group changes
Sep 18, 2018
Herst
force-pushed
the
next-input-group
branch
from
September 21, 2018 07:56
4e7e5ae
to
cdf0e2e
Compare
Herst
force-pushed
the
next
branch
2 times, most recently
from
November 10, 2018 17:34
622ae8b
to
65d8daf
Compare
Herst
changed the title
[v.next] Adapt for input group changes
[v1] Adapt for input group changes
Dec 26, 2018
Herst
force-pushed
the
next-input-group
branch
2 times, most recently
from
July 26, 2019 14:25
96a7a37
to
bb98379
Compare
Apparently the changes to the tests got lost, redoing them. |
Herst
force-pushed
the
next-input-group
branch
4 times, most recently
from
July 29, 2019 07:10
f536c01
to
a86c9f6
Compare
66 tasks
From a quick look it's looks OK. I don't have the time to properly review this, though. |
E006, E010, E015 removed E009, E011, E012 ported
Herst
force-pushed
the
next-input-group
branch
from
August 19, 2019 07:18
edd016e
to
2eee681
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking aloud
.input-group
contains a<select>
/<textarea>
) ➜ Works now with<select>
/<textarea>
with the.form-control
/.custom-select
classes respectively (https://getbootstrap.com/docs/4.1/components/input-group/#custom-select/https://getbootstrap.com/docs/4.1/components/input-group/#basic-example) ➜ Replace with new checks in future ([v1] (Possible) checks to be added #424) but remove for now.input-group
s can cause issues.) ➜ Still applies? ➜ Change.input-lg
into.form-control-lg
.form-control
s) ➜ Works at least with multiple<input>
s except for validation (https://getbootstrap.com/docs/4.1/components/input-group/#multiple-inputs) ➜ Warning? Remove for now.and
.form-groupcannot be used directly on the same element) ➜ Still applies I guess ➜ Port by adding
row/
.form-row`and
.col--` cannot be used directly on the same element) ➜ PortChanges
E006, E010, E015 removed and E009, E011, E012, E044 ported
Status