Fix static analysis issues

ts-navghane · Jul 17, 2023 · b7489b0 · b7489b0
1 parent 9b7e499
commit b7489b0
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 3 deletions.
diff --git a/EventSubscriber/CallbackSubscriber.php b/EventSubscriber/CallbackSubscriber.php
@@ -66,7 +66,7 @@ public function processCallbackRequest(TransportWebhookEvent $event): void
     }
 
     /**
-     * @param string $hashId
+     * @param string       $hashId
      * @param array<mixed> $event
      */
     private function processCallbackByHashId($hashId, array $event): void
@@ -94,7 +94,7 @@ private function processCallbackByHashId($hashId, array $event): void
     }
 
     /**
-     * @param string $email
+     * @param string       $email
      * @param array<mixed> $event
      */
     private function processCallbackByEmailAddress($email, array $event): void

diff --git a/Mailer/Factory/SparkpostTransportFactory.php b/Mailer/Factory/SparkpostTransportFactory.php
@@ -17,8 +17,8 @@
 class SparkpostTransportFactory extends AbstractTransportFactory
 {
     public function __construct(
-        EventDispatcherInterface $eventDispatcher,
         private TransportCallback $transportCallback,
+        EventDispatcherInterface $eventDispatcher,
         HttpClientInterface $client = null,
         LoggerInterface $logger = null
     ) {

diff --git a/Mailer/Transport/SparkpostTransport.php b/Mailer/Transport/SparkpostTransport.php
@@ -209,6 +209,9 @@ private function buildAttachments(MauticMessage $message): array
     }
 
     /**
+     * @param array<mixed> $metadata
+     * @param array<mixed> $mergeVars
+     *
      * @return array<mixed>
      */
     private function buildRecipients(MauticMessage $message, array $metadata, array $mergeVars): array
@@ -235,6 +238,9 @@ private function buildRecipients(MauticMessage $message, array $metadata, array
     }
 
     /**
+     * @param array<mixed> $metadata
+     * @param array<mixed> $mergeVars
+     *
      * @return array<mixed>
      */
     private function buildRecipient(Address $to, array $metadata, array $mergeVars): array
@@ -277,6 +283,8 @@ private function buildRecipient(Address $to, array $metadata, array $mergeVars):
     }
 
     /**
+     * @param array<mixed> $recipient
+     *
      * @return array<mixed>
      */
     private function buildCopyRecipient(Address $to, Address $copy, array $recipient): array
@@ -293,6 +301,10 @@ private function buildCopyRecipient(Address $to, Address $copy, array $recipient
         return $copyRecipient;
     }
 
+    /**
+     * @param array<mixed> $metadata
+     * @param array<mixed> $metadataSet
+     */
     private function getCampaignId(array $metadata, array $metadataSet): string
     {
         $campaignId = '';
@@ -315,6 +327,8 @@ private function getCampaignId(array $metadata, array $metadataSet): string
     }
 
     /**
+     * @param array<mixed> $payload
+     *
      * @throws ClientExceptionInterface
      * @throws RedirectionExceptionInterface
      * @throws ServerExceptionInterface
@@ -345,6 +359,8 @@ private function checkTemplateIsValid(array $payload): void
     }
 
     /**
+     * @param array<mixed> $payload
+     *
      * @throws TransportExceptionInterface
      */
     private function getSparkpostResponse(
@@ -383,11 +399,19 @@ private function handleError(ResponseInterface $response): void
         throw new HttpTransportException(json_encode($data['errors']), $response, $response->getStatusCode());
     }
 
+    /**
+     * @param array<mixed> $response
+     */
     private function getErrorMessageFromResponseBody(array $response): string
     {
         return $response['errors'][0]['description'] ?? $response['errors'][0]['message'] ?? '';
     }
 
+    /**
+     * @param array<mixed> $message
+     * @param array<mixed> $response
+     * @param array<mixed> $metadata
+     */
     private function processImmediateSendFeedback(array $message, array $response, array $metadata): void
     {
         if (!empty($response['errors'][0]['code']) && 1902 === (int) $response['errors'][0]['code']) {