Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add commitizen and documentation changes #118

Merged
merged 3 commits into from
May 10, 2017
Merged

chore: Add commitizen and documentation changes #118

merged 3 commits into from
May 10, 2017

Conversation

markhalliwell
Copy link
Contributor

Description

  • Add commitizen dependency
  • Add helper script
  • Add documentation

Related Issue

Merge checklist (required, for maintainers only)

This pull request adheres to the following requirements:

  • JavaScript follows 4 space indentation conventions.
  • JavaScript was written using ES2015 (ES6) features.
  • Features and bug fixes are covered by test cases.
  • All commits follow the AngularJS Git Commit Message Conventions.

@truckingsim
Copy link
Owner

@MarkCarver the only thing I would change is we will have other linting rules. So maybe instead of specifying one layout problem we like 4 spaces we say all editorconfig and linting rules. I think we should require an editor that uses editorconfig whether builtin or through a plugin, and then once we add linting we specify that needs to pass too.

@markhalliwell
Copy link
Contributor Author

Sure.

While specifying to this level of detail is not inaccurate, I don't see this as a blocker for this PR.

I'm less worried about the documentation aspects as these will, undoubtedly, evolve quite a bit over time.

This at least gets this going.

@truckingsim
Copy link
Owner

Yeah agreed don't think any of what I said should be a blocker. Its infinitely better than what we have now that's for sure.

@markhalliwell markhalliwell merged commit 4d88c9c into truckingsim:dev May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants