[WIP] Framework: Expand CodeQL job to run on all non-deprecated packages modified at a time #13478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Want to test the difference in speed with its current configuration settings on a self-hosted machine (using our gcc-serial containers for now). Signed-off-by: Anderson Chauphan <[email protected]>
achauphan
added
AT: WIP
Signed-off-by: Anderson Chauphan <[email protected]>
achauphan
added
AT2-SpecialApprove
achauphan
added
AT2-SpecialApprove
Our gcc-openmpi runner has the necessary TPLs required to configure and build.
achauphan
added
AT2-SpecialApprove
|
Looks reasonable to me! @achauphan |
achauphan
added
AT2-SpecialApprove
Move get dependencies to its own step to utilize unique bash arguments. This is due to how LoadEnv from GenConfig spawns a subshell.
sebrowne
reviewed
Oct 2, 2024
.github/workflows/codeql.yml
Outdated
| cd trilinos_build | ||
|
|
||
| bash ${GITHUB_WORKSPACE}/packages/framework/GenConfig/LoadEnv/load-env.sh --force rhel8_gcc-openmpi_debug_shared_no-kokkos-arch_no-asan_complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables | ||
|
|
||
| cmake -G 'Unix Makefiles' -DTrilinos_ENABLE_TESTS=OFF -DTrilinos_ENABLE_Epetra=OFF -DTrilinos_ENABLE_AztecOO=OFF -DTrilinos_ENABLE_Ifpack=OFF -DTrilinos_ENABLE_ML=OFF -D Trilinos_ENABLE_Triutils=OFF -DTrilinos_ENABLE_Tpetra=ON -DTrilinos_ENABLE_MueLu=ON -DTrilinos_ENABLE_Krino=OFF .. |
There was a problem hiding this comment.
This needs to be changed to build the correct set of packages (the ones modified as part of this PR, but not downstream ones).
Could also use the PR scripts to facilitate this, and maybe add the configure option that turns off downstream packages (something like Trilinos_ENABLE_DOWNSTREAM_PACKAGES ish)? Using GenConfig will likely fix your issues with not finding TPLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/framework @csiefer2
Motivation
The current CodeQL test configuration will run only on Tpetra and MueLu. We want to expand CodeQL's analysis to include all non-deprecated packages that were modified in a PR (ignore downstream packages).
Doing so will increase build time, so this will need to run on our self-hosted runners being spawned by the AutoTester2.
Related Issues
Testing
Testing CodeQL changes will occur within this PR using the AutoTester2 system while the
[WIP]label is being used.