-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add junit.xml to gitignore #3060
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you want to consider this alternative: There is also an option that can be set under jest-junit
in jest.config.js
:
outputDirectory: "/tmp"
Thanks for looking into this. It escaped my attention and should have been handled in a way similar to the mix tests, when I introduced these junit deps.
No worries @gagandeepb, I just stumbled upon this right now. Can you do the same for the other tests? |
a2c3fba
to
b5744ee
Compare
For the other categories of tests: |
For jest tests, the write destination of the junit files can also be customized/overridden, if needed, like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but lol that's random... isn't that Java normally?
Description
Right now a
junit.xml
file gets generated uponnpm test
, I'm just adding it to the gitignore in order to avoid committing it by mistake.