Projectors refactor #1624
Merged
Projectors refactor #1624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested changes
Jul 13, 2023
There was a problem hiding this comment.
@CDimonaco I still see some Repo.queries in the after_updates that shouldn't be there:
- Cluster projection,
ClusterDeregisteredevent. This is the unique real change i ask you XD - Host projection,
HostAddedToCluster, you could add thereturning: truevalue to theinsert, so you get the data from the database, and you don't need to query in theafter_update. Anywayinsertfirstquerylater is accepted as a good solution as well.
Ref
| @@ -63,8 +63,10 @@ defmodule Trento.ClusterProjector do | |||
| deregistered_at: deregistered_at | |||
| }, | |||
| fn multi -> | |||
| cluster = Repo.get!(ClusterReadModel, cluster_id) | |||
There was a problem hiding this comment.
Just as a comment, in other project functions, we have this pipelined:
changeset =
ClusterReadModel
|> Repo.get!(cluster_id)
|> ClusterReadModel.changeset(%{
deregistered_at: deregistered_at
})
Just in case if you prefer it 😝
There was a problem hiding this comment.
You triggered my ocd 👁️
Everything refactored to this style
|
@CDimonaco Besides the review, can you make me a small favor? XD |
|
Everything done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr refactor the usage of projectors, using the changesets with the current entity as the base entity for the changes.
Removes the queries from
after_updatecallbacks, only the necessary association preloads for broadcasts are present.How was this tested?
Automated tests