Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only broadcast
HostRemovedFromCluster
when a host is part of a cluster #1611Only broadcast
HostRemovedFromCluster
when a host is part of a cluster #1611Changes from 4 commits
d615d40
8f87ce1
6d4ac87
762e367
21834be
f406559
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just a bit worried about this
1000
value.In the
refute
this blocks the test until the timeout is expired, so it will be waiting for 1 second to have a green test.Maybe we should use the default
100
value?@CDimonaco @fabriziosestito Any suggestion on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the 1000 value was set by me when I started doing broadcast test, this was set by testing manually different values, if the default timeout is sufficient we can switch to that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, in
assert_broadcast
is fine, because it will just wait until the message is sent. And it will be a long test only on failure.The
refute
will always wait for the time, even in passing tests.That's the difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reduced this timeout to 100 mS 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a least request XD
Could you test if putting this same
refute_broadcast
with 100ms in the test above fails? Of course, just temporarily, in your local env.It should fail. I want to be sure that the 100ms makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did on my local machine and
refute_broadcast
can catch messages using atimeout
as low as 1 mS 😵 I guess we may see different performance in the CI environment though.